Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract library instrumentation for lettuce 5.1 #2533

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Extract library instrumentation for lettuce 5.1 #2533

merged 1 commit into from
Mar 10, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Mar 9, 2021

Preparation for #2529

@anuraaga
Copy link
Contributor Author

anuraaga commented Mar 9, 2021

Github's not rendering this diff well :( The test files are mostly just copy-paste, except I had to keep one async test in the javaagent directory since it seems to rely on executor instrumentation for now. Otherwise no real logic change, just making Tracer a parameter to OpenTelemetryTracing per usual pattern.

@anuraaga anuraaga merged commit cf6d9de into open-telemetry:main Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anuraaga @mateuszrzeszutek