-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RestTemplateInterceptor so that it calls endExceptionally() on exception #2516
Fix RestTemplateInterceptor so that it calls endExceptionally() on exception #2516
Conversation
Maybe we could also test it the same way as we do for other http clients.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also test it the same way as we do for other http clients.
👍
Yeah, definitely 🤦♂️ I don't know how I did not think of this earlier 😅 |
Done! |
61f1e82
to
ff0645d
Compare
Resolves #2479
I've added a few testing changes in this PR because I wouldn't be able to unit-test my change otherwise:
TraceUtils
class in testing-common; contrary to the old one it usesBaseTracer
to create spans, so we can now test span suppression;