-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Grails #2512
Add support for Grails #2512
Conversation
laurit
commented
Mar 5, 2021
- set server span name to /context/controller/action
- create span for grails controller invocations
instrumentation/grails-3.0/javaagent/grails-3.0-javaagent.gradle
Outdated
Show resolved
Hide resolved
.../javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/grails/GrailsTracer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/javaagent/instrumentation/springwebmvc/SpringWebMvcTracer.java
Outdated
Show resolved
Hide resolved
instrumentation/grails-3.0/javaagent/src/test/groovy/test/GrailsTest.groovy
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set server span name to /context/controller/action
Is it possible to get and use the url-based route instead?
...telemetry/javaagent/instrumentation/grails/UrlMappingsInfoHandlerAdapterInstrumentation.java
Outdated
Show resolved
Hide resolved
instrumentation/grails-3.0/javaagent/src/test/groovy/test/GrailsTest.groovy
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/javaagent/instrumentation/springwebmvc/SpringWebMvcTracer.java
Outdated
Show resolved
Hide resolved
I think that span name based on I don't have a good suggestion atm. |
Ya, me either, that's why I'm hoping there's a reasonable way to get and use the url-based route.
Interestingly the rpc semantic conventions use |
It might be better to just accept that span name is something that identifies a trace. How exactly will depend on the circumstances, it might not be possible to always get a result that immediately makes sense.
So I'd assume that |
@laurit convinced me on the status quo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/$controller/$action?/$id?(.$format)?"
oh my, I see why this is problematic
With some effort it might be possible to replace controller and action wildcards in pattern with actual names and translate parameter wildcards back to variable names.
agree status quo is good, thanks for the explanations 👍