Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instrumentation for rocketmq #2263

Merged
merged 57 commits into from
Mar 11, 2021
Merged

Add instrumentation for rocketmq #2263

merged 57 commits into from
Mar 11, 2021

Conversation

addname
Copy link
Member

@addname addname commented Feb 12, 2021 •
edited by pavolloffay
Loading

add rocketmq support

Resolves #1916

@addname addname changed the title Issue#1916 add rocketmq support issue#1916 Feb 16, 2021
@addname addname changed the title add rocketmq support issue#1916 Add rocketmq support Feb 16, 2021
@addname addname changed the title Add rocketmq support Add instrumentation for rocketmq Feb 18, 2021
@addname addname mentioned this pull request Feb 19, 2021
Closed
mateuszrzeszutek
mateuszrzeszutek reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for contributing! I've left a few comments, please take a look at them 🙏

Sorry for taking so long to review this PR, it somehow went under our radar 😞

.../library/src/main/java/io/opentelemetry/instrumentation/rocketmq/RocketMqConsumerTracer.java Outdated Show resolved Hide resolved
...8/library/src/main/java/io/opentelemetry/instrumentation/rocketmq/TextMapExtractAdapter.java Outdated Show resolved Hide resolved
...8/library/src/main/java/io/opentelemetry/instrumentation/rocketmq/TextMapExtractAdapter.java Outdated Show resolved Hide resolved
....8/library/src/main/java/io/opentelemetry/instrumentation/rocketmq/TextMapInjectAdapter.java Outdated Show resolved Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/rocketmq/RocketMqProducerTracer.java Outdated Show resolved Hide resolved
instrumentation/rocketmq-client-4.8/testing/src/main/java/base/BaseConf.java Outdated Show resolved Hide resolved
instrumentation/rocketmq-client-4.8/testing/src/main/java/base/IntegrationTestBase.java Outdated Show resolved Hide resolved
instrumentation/rocketmq-client-4.8/testing/src/main/java/base/IntegrationTestBase.java Outdated Show resolved Hide resolved
instrumentation/rocketmq-client-4.8/testing/src/main/java/base/IntegrationTestBase.java Outdated Show resolved Hide resolved
instrumentation/rocketmq-client-4.8/testing/src/main/java/base/IntegrationTestBase.java Outdated Show resolved Hide resolved
anuraaga
anuraaga reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, almost there

...ent-4.8/library/src/main/java/io/opentelemetry/instrumentation/rocketmq/RocketMqTracing.java Show resolved Hide resolved
addname and others added 3 commits March 9, 2021 14:36
anuraaga
anuraaga approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@addname
Copy link
Member Author

addname commented Mar 9, 2021

I am also very grateful to @anuraaga and @mateuszrzeszutek . This is not only a very challenging thing, but also things that can learn a lot. I will always pay attention to the development of the opentelemery community.:smiley:

mateuszrzeszutek
mateuszrzeszutek reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've got just a few more minor comments, but other than that it looks really good 👍

...ent-4.8/library/src/main/java/io/opentelemetry/instrumentation/rocketmq/ContextAndScope.java Outdated Show resolved Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/rocketmq/RocketMqTracingBuilder.java Outdated Show resolved Hide resolved
...ent-4.8/library/src/main/java/io/opentelemetry/instrumentation/rocketmq/RocketMqTracing.java Outdated Show resolved Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/rocketmq/RocketMqConsumerTracer.java Outdated Show resolved Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/rocketmq/RocketMqConsumerTracer.java Outdated Show resolved Hide resolved
instrumentation/rocketmq-client-4.8/testing/src/main/java/base/IntegrationTestBase.java Show resolved Hide resolved
instrumentation/rocketmq-client-4.8/testing/src/main/java/base/BaseConf.java Outdated Show resolved Hide resolved
@addname
Copy link
Member Author

addname commented Mar 10, 2021

muzzle (:instrumentation:kotlinx-coroutines:javaagent) failed, how to deal with it?

mateuszrzeszutek
mateuszrzeszutek approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mateuszrzeszutek
Copy link
Member

muzzle (:instrumentation:kotlinx-coroutines:javaagent) failed, how to deal with it?

That looks like a random failure, I'll re-run these checks for you.

@iNikem iNikem merged commit ee66554 into open-telemetry:main Mar 11, 2021
@trask
Copy link
Member

trask commented Mar 11, 2021

Thanks @addname!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

@anuraaga anuraaga Awaiting requested review from anuraaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rocketMq support
5 participants
@addname @mateuszrzeszutek @trask @anuraaga @iNikem