Skip to content

ci: update to rust version of flint#18114

Merged
trask merged 41 commits intoopen-telemetry:mainfrom
zeitlinger:flint-v2-lychee
Apr 30, 2026
Merged

ci: update to rust version of flint#18114
trask merged 41 commits intoopen-telemetry:mainfrom
zeitlinger:flint-v2-lychee

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented Apr 21, 2026

This updates the existing markdown and link linting to the current Rust-based flint release.

What changes in this PR:

  • install flint from github:grafana/flint = "0.20.3"
  • run the existing markdown and link checks through flint instead of the old remote shell task plus separate markdownlint wiring
  • keep the existing lychee configuration under .github/config
  • enable check_all_local = true so local links are checked across the repo

Why markdown-lint-check is now captured:

  • markdownlint-cli2 was already part of this repo
  • once flint is added, it discovers and runs markdownlint-cli2 from mise.toml
  • that means the old dedicated markdownlint workflow and shell task would be duplicate CI logic
  • this PR removes that duplicate path and lets the existing markdown lint run through the same flint-based lint entrypoint as link checking

This is the smaller first step. The broader flint migration remains in the follow-up PR.

Verification:

  • mise run lint

@zeitlinger zeitlinger changed the title ci: migrate link checks to flint ci: update to rust version of flint Apr 21, 2026
@zeitlinger zeitlinger changed the title ci: update to rust version of flint ci: update to rust version of flint for link checks Apr 21, 2026
@zeitlinger zeitlinger changed the title ci: update to rust version of flint for link checks ci: update to rust version of flint Apr 21, 2026
@zeitlinger zeitlinger marked this pull request as ready for review April 21, 2026 12:11
@zeitlinger zeitlinger requested a review from a team as a code owner April 21, 2026 12:11
@zeitlinger zeitlinger marked this pull request as draft April 23, 2026 18:23
@otelbot-java-instrumentation otelbot-java-instrumentation Bot added the test native This label can be applied to PRs to trigger them to run native tests label Apr 26, 2026
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger marked this pull request as ready for review April 28, 2026 06:11
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Comment on lines +66 to +69
(
!startsWith(github.base_ref, 'release/') &&
needs.lint.result != 'success'
)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this because link checks are now part of lint? can we split it out so that link checks aren't a required status check? or are you thinking that with the link check only applying to diffs it shouldn't cause PRs to get blocked?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this because link checks are now part of lint?

yes

can we split it out so that link checks aren't a required status check?

in flint that's currently not possible - but could be added

or are you thinking that with the link check only applying to diffs it shouldn't cause PRs to get blocked?

yes - that was the idea

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's try it

cc @laurit

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@trask trask enabled auto-merge (squash) April 30, 2026 15:27
@trask trask merged commit 6eb4137 into open-telemetry:main Apr 30, 2026
181 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants