Add getDbName() to DbClientAttributesGetter to better support old / stable semconv split#16318
Merged
trask merged 1 commit intoopen-telemetry:mainfrom Mar 2, 2026
Merged
Conversation
Add a deprecated getDbName() default method to DbClientAttributesGetter that allows instrumentations to return a different value for the old db.name attribute vs the new db.namespace attribute. Use getDbName() in DbClientAttributesExtractor (for DB_NAME) and DbClientSpanNameExtractor (for old semconv span names) instead of getDbNamespace(). The default implementation delegates to getDbNamespace() so existing instrumentations are unaffected.
trask
force-pushed
the
pr1-semconv-getDbName
branch
from
c5f5054 to
7b49b49
Compare
laurit
reviewed
Mar 2, 2026
| */ | ||
| @Deprecated // to be removed in 3.0 | ||
| @Nullable | ||
| default String getDbName(REQUEST request) { |
Contributor
There was a problem hiding this comment.
I guess an alternative would be to se an internal interface
Member
Author
There was a problem hiding this comment.
Similar to #16304 (comment), I kind of like making it public to support anyone outside of this repo going through the transition, although maybe that's not too realistic since they'd have to stick to our timeline as we'll be removing them in 3.0
laurit
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow instrumentations to emit different values for
db.name(old semconv) anddb.namespace(new semconv), which is needed for a few databases where these values are different (e.g. postgresql, sqlserver).