Add dual-semconv support to RPC attributes extractors by zeitlinger · Pull Request #16130 · open-telemetry/opentelemetry-java-instrumentation

zeitlinger · 2026-02-10T14:13:49Z

Part of Add RPC semantic convention stable opt-in support #15932 — split into smaller reviewable PRs. This is PR 3 of 5 (depends on Expand RpcAttributesGetter interface for stable RPC semconv support #16121).
RpcCommonAttributesExtractor now conditionally emits old (rpc.system, rpc.service, rpc.method) and/or stable (rpc.system.name, rpc.method, rpc.method_original, error.type) attributes based on SemconvStability flags
RpcSpanNameExtractor uses getRpcMethod() for stable semconv with system name fallback
In dup mode, old rpc.method is omitted from spans to avoid clashing with stable rpc.method.
Adds RpcAttributesGetter.isPredefined() for rpc.method vs rpc.method_original handling

…xtractor RpcCommonAttributesExtractor now conditionally emits old (rpc.system, rpc.service, rpc.method) and/or stable (rpc.system.name, rpc.method, rpc.method_original, error.type) attributes based on SemconvStability flags. RpcSpanNameExtractor uses getRpcMethod() for stable semconv with system name fallback. In dup mode, old rpc.method is omitted from spans to avoid clashing with stable rpc.method. Instead, a ContextCustomizer stores the old method value in context via a ContextKey for metrics to read. Also adds RpcAttributesGetter.isPredefined() for rpc.method vs rpc.method_original handling.

...a/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesExtractorTest.java

zeitlinger · 2026-02-12T19:50:19Z

@trask please take a look

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java

...ava/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcSpanNameExtractorTest.java

...in/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcSpanNameExtractor.java

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java

trask · 2026-02-13T18:03:16Z

...io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcCommonAttributesExtractor.java

-    internalSet(attributes, RPC_SYSTEM, getter.getSystem(request));
-    internalSet(attributes, RPC_SERVICE, getter.getService(request));
-    internalSet(attributes, RPC_METHOD, getter.getMethod(request));
+    String system = getter.getSystem(request);


let's introduce getRpcSystemName

mark getSystem as deprecated // to be removed in 3.0

then the getter can be responsible for returning the stable / old name from each of the methods

I realize this is different from what we did with database, but I think it would be better

Done — added getRpcSystemName() as default method, deprecated getSystem() with "to be removed in 3.0". Extractor now calls getRpcSystemName() directly for stable semconv instead of going through stableRpcSystemName() mapping.

- Add getRpcSystemName() to RpcAttributesGetter, deprecate getSystem() - Remove isPredefined() and RPC_METHOD_ORIGINAL — defer until use case exists - Getter implementations now responsible for returning stable/old system names - Remove system fallback in RpcSpanNameExtractor (system name is required) - Simplify test setup per reviewer suggestions Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Resolve merge conflicts by keeping dual-semconv support changes. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

… removal Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

...in/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcSpanNameExtractor.java

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java

...io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcCommonAttributesExtractor.java

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java

… fixes Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

...in/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcSpanNameExtractor.java

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

…terface method

zeitlinger self-assigned this Feb 10, 2026

zeitlinger requested a review from a team as a code owner February 10, 2026 14:13

zeitlinger mentioned this pull request Feb 10, 2026

Expand RpcAttributesGetter interface for stable RPC semconv support #16121

Merged

zeitlinger force-pushed the pr3-rpc-dual-semconv-extractors branch from a1e958a to fc4a9eb Compare February 10, 2026 14:19

steverao reviewed Feb 11, 2026

View reviewed changes

...a/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesExtractorTest.java Outdated Show resolved Hide resolved

zeitlinger added 2 commits February 11, 2026 17:16

pr review

869670a

pr review

1a5cf07

trask reviewed Feb 12, 2026

View reviewed changes

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java Outdated Show resolved Hide resolved

zeitlinger mentioned this pull request Feb 13, 2026

RPC stable opt-in #15879

Draft

trask reviewed Feb 13, 2026

View reviewed changes

zeitlinger added 3 commits February 20, 2026 13:42

Merge main into pr3-rpc-dual-semconv-extractors

1ecb0cf

Resolve merge conflicts by keeping dual-semconv support changes. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Replace internalSet with attributes.put after AttributesExtractorUtil…

69a898a

… removal Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

trask reviewed Feb 24, 2026

View reviewed changes

...in/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcSpanNameExtractor.java Outdated Show resolved Hide resolved

trask reviewed Feb 24, 2026

View reviewed changes

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java Outdated Show resolved Hide resolved

trask reviewed Feb 24, 2026

View reviewed changes

...io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcCommonAttributesExtractor.java Outdated Show resolved Hide resolved

trask reviewed Feb 24, 2026

View reviewed changes

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java Outdated Show resolved Hide resolved

...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java Outdated Show resolved Hide resolved

zeitlinger added 2 commits February 24, 2026 08:09

Address review feedback: system name fallback, TODO comments, javadoc…

83ffb47

… fixes Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Fix spotless: use static imports for SemconvStability methods

7b59479

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

zeitlinger force-pushed the pr3-rpc-dual-semconv-extractors branch from e06b3a5 to 7b59479 Compare February 24, 2026 16:46

Merge branch 'main' into pr3-rpc-dual-semconv-extractors

645034c

trask reviewed Feb 24, 2026

View reviewed changes

...in/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcSpanNameExtractor.java Outdated Show resolved Hide resolved

zeitlinger added 2 commits February 25, 2026 14:18

Fix spotless: use static imports for RpcIncubatingAttributes constants

2622a3e

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Make getRpcSystemName non-nullable, default to getSystem()

efc5ca8

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

trask approved these changes Feb 25, 2026

View reviewed changes

trask added 3 commits February 25, 2026 11:02

Fix RpcSpanNameExtractorTest to use thenCallRealMethod for default in…

4ede0fe

…terface method

update

4183e63

Merge branch 'main' into pr3-rpc-dual-semconv-extractors

af4d05a

trask merged commit 55c6d21 into open-telemetry:main Feb 25, 2026
85 checks passed

zeitlinger deleted the pr3-rpc-dual-semconv-extractors branch February 26, 2026 10:00

This was referenced Feb 26, 2026

Add dual-semconv support to RPC metrics #16297

Closed

Add dual-semconv support to RPC metrics #16298

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dual-semconv support to RPC attributes extractors#16130

Add dual-semconv support to RPC attributes extractors#16130
trask merged 14 commits intoopen-telemetry:mainfrom
zeitlinger:pr3-rpc-dual-semconv-extractors

zeitlinger commented Feb 10, 2026 •

edited by trask

Loading

Uh oh!

Uh oh!

zeitlinger commented Feb 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trask Feb 13, 2026

Uh oh!

zeitlinger Feb 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zeitlinger commented Feb 10, 2026 • edited by trask Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

zeitlinger commented Feb 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trask Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

zeitlinger Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeitlinger commented Feb 10, 2026 •

edited by trask

Loading