Skip to content

Remove declarative config bridge from agent#15778

Merged
trask merged 4 commits intoopen-telemetry:mainfrom
zeitlinger:remove-declarative-config-bridge-from-agent
Jan 22, 2026
Merged

Remove declarative config bridge from agent#15778
trask merged 4 commits intoopen-telemetry:mainfrom
zeitlinger:remove-declarative-config-bridge-from-agent

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented Jan 6, 2026

No description provided.

@zeitlinger zeitlinger self-assigned this Jan 6, 2026
@zeitlinger zeitlinger force-pushed the remove-declarative-config-bridge-from-agent branch from 17d5f8c to 9c44f65 Compare January 9, 2026 16:37
@zeitlinger zeitlinger marked this pull request as ready for review January 10, 2026 05:18
@zeitlinger zeitlinger requested a review from a team as a code owner January 10, 2026 05:18
@zeitlinger zeitlinger added this to the v2.24.0 milestone Jan 10, 2026
@zeitlinger zeitlinger force-pushed the remove-declarative-config-bridge-from-agent branch from 2ca445c to 2c3a9f7 Compare January 13, 2026 06:51
@zeitlinger zeitlinger moved this to Awaiting Review in Declarative Configuration: Java Jan 13, 2026
@trask
Copy link
Copy Markdown
Member

trask commented Jan 13, 2026

I think we need to keep this bridge until we remove the deprecated methods that are still using ConfigProperties

@zeitlinger
Copy link
Copy Markdown
Member Author

I think we need to keep this bridge until we remove the deprecated methods that are still using ConfigProperties

No those are not using this bridge - use explicit fallback instead.

In fact, only contrib extensions use this bridge at this point.

@trask
Copy link
Copy Markdown
Member

trask commented Jan 13, 2026

what if someone has an extension with

  • IgnoredTypesConfigurer
  • InstrumentationModule

using one of those deprecated ConfigProperties methods?

@zeitlinger
Copy link
Copy Markdown
Member Author

what if someone has an extension with

  • IgnoredTypesConfigurer
  • InstrumentationModule

using one of those deprecated ConfigProperties methods?

That's a good point. We have to decide if we want to support ConfigProperties in those extensions together with declarative config, which is still experimental.
I would say we sholudn't try to do that, it only creates some things that still don't work - like the new "distribution" node support added in #15822.

@trask trask removed this from the v2.24.0 milestone Jan 16, 2026
@trask
Copy link
Copy Markdown
Member

trask commented Jan 22, 2026

I would say we shouldn't try to do that, it only creates some things that still don't work

good point, extensions (e.g. adding span processors) generally need to do work anyways to support declarative configuration

@trask trask merged commit 3f9a1fd into open-telemetry:main Jan 22, 2026
85 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Done in Declarative Configuration: Java Jan 22, 2026
@zeitlinger zeitlinger deleted the remove-declarative-config-bridge-from-agent branch January 22, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants