Update DeclarativeConfigUtil to support general node#15704
Update DeclarativeConfigUtil to support general node#15704trask merged 3 commits intoopen-telemetry:mainfrom
Conversation
| public static ExtendedDeclarativeConfigProperties getInstrumentationConfig( | ||
| OpenTelemetry openTelemetry, String instrumentationName) { | ||
| return getConfig(openTelemetry).get("java").get(instrumentationName); | ||
| } | ||
|
|
||
| public static ExtendedDeclarativeConfigProperties getGeneralInstrumentationConfig( | ||
| OpenTelemetry openTelemetry) { | ||
| return getConfig(openTelemetry).get("general"); | ||
| } |
There was a problem hiding this comment.
currently proposed naming from open-telemetry/opentelemetry-java#7927
| public boolean indyEnabled() { | ||
| return config.get("agent").getBoolean("indy/development", false); | ||
| } | ||
|
|
There was a problem hiding this comment.
removed this from ExperimentalConfig because it really belongs in some kind of "distribution config" which deserves a different abstraction, related to open-telemetry/opentelemetry-specification#4800 (comment)
| commonConfig | ||
| .get("messaging") |
There was a problem hiding this comment.
Moved the common messaging configuration under .instrumentation.java.common.messaging.
| return commonConfig | ||
| .get("messaging") |
| indyEnabled = | ||
| AgentInstrumentationConfig.get().getBoolean("otel.javaagent.experimental.indy", false); |
There was a problem hiding this comment.
will come back to this an create some kind of "distribution config" abstraction
not saying we should, but even if we decide to keep it under .instrumentation.java.agent.* (and not use the .distribution.*), I still don't think this property belongs in ExperimentalConfig with the other .instrumentation.java.common.* properties
2 participants
No description provided.