Skip to content

Remove AgentInstrumentationConfig usages: Scheduling#15674

Closed
trask wants to merge 1 commit intoopen-telemetry:mainfrom
trask:declarative-config/b-scheduling
Closed

Remove AgentInstrumentationConfig usages: Scheduling#15674
trask wants to merge 1 commit intoopen-telemetry:mainfrom
trask:declarative-config/b-scheduling

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Dec 16, 2025

Towards #15599

These only had a single property, so didn't extract Configuration class.

Also, with new API we're landing on, I don't think the Configuration class is as necessary anymore.

@trask trask marked this pull request as ready for review December 16, 2025 21:12
@trask trask requested a review from a team as a code owner December 16, 2025 21:12
@trask trask marked this pull request as draft December 17, 2025 03:17
.getBoolean("otel.instrumentation.quartz.experimental-span-attributes", false))
DeclarativeConfigUtil.get(GlobalOpenTelemetry.get())
.get("quartz")
.getBoolean("experimental_span_attributes", false))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use /development suffix

@trask
Copy link
Copy Markdown
Member Author

trask commented Dec 18, 2025

Closing, going to re-do with (really) minimal changes over to declarative configuration API (including not removing ExperimentalConfig and CommonConfig)

@trask trask closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants