Fix benchmark-overhead compilation #13418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
trask
commented
Feb 28, 2025
Comment on lines
-36
to
-39
| testLogging { | ||
| exceptionFormat = TestExceptionFormat.FULL | ||
| showStandardStreams = true | ||
| } |
There was a problem hiding this comment.
this ends up being very verbose when actually running the tests (and didn't help with this junit issue anyways)
trask
commented
Feb 28, 2025
Comment on lines
+500
to
+501
| run: ./gradlew assemble ${{ inputs.no-build-cache && ' --no-build-cache' || '' }} | ||
| working-directory: benchmark-overhead |
There was a problem hiding this comment.
this would have caught the failure on updating junit
laurit
approved these changes
Feb 28, 2025
jaydeluca
approved these changes
Feb 28, 2025
chlos
pushed a commit
to chlos/opentelemetry-java-instrumentation
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and add a CI check)