Fix adding logback mdc appender in spring starter #13391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
zeitlinger
approved these changes
Feb 28, 2025
jeanbisutti
reviewed
Feb 28, 2025
...nstrumentation/spring/autoconfigure/internal/instrumentation/logging/CustomListAppender.java
Outdated
Show resolved
Hide resolved
...entation/spring/autoconfigure/internal/instrumentation/logging/LogbackAppenderInstaller.java
Outdated
Show resolved
Hide resolved
jeanbisutti
approved these changes
Feb 28, 2025
trask
reviewed
Feb 28, 2025
| @@ -132,6 +132,7 @@ testing { | |||
| implementation("org.springframework.boot:spring-boot-autoconfigure:$springBootVersion") | |||
|
|
|||
| implementation(project(":instrumentation:logback:logback-appender-1.0:library")) | |||
| compileOnly(project(":instrumentation:logback:logback-mdc-1.0:library")) | |||
There was a problem hiding this comment.
I didn't follow how this compileOnly dep is used?
There was a problem hiding this comment.
I changed the scope to implementation, hopefully that is less confusing. A class from the logback-mdc-1.0:library is used in a test so it is needed to compile the test, I think it gets added to runtime dependencies because the main project depends on it and the suite depends on the main project.
trask
approved these changes
Feb 28, 2025
chlos
pushed a commit
to chlos/opentelemetry-java-instrumentation
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13383