-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the OpenTelemetry SDK version to 1.42.0 #12186
Update the OpenTelemetry SDK version to 1.42.0 #12186
Conversation
@@ -29,15 +30,19 @@ void noopInstance() { | |||
Meter meter = testing.getOpenTelemetry().getMeter("test"); | |||
|
|||
LongCounterBuilder counterBuilder = meter.counterBuilder("test"); | |||
assertThat(counterBuilder).isNotInstanceOf(ExtendedLongCounterBuilder.class); | |||
assertThat(counterBuilder).isInstanceOf(ExtendedLongCounterBuilder.class); | |||
((ExtendedLongCounterBuilder) counterBuilder).setAttributesAdvice(emptyList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this setting empty attributesAdvice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was introduced in #11934 We verified that when the underlying instrument is noop then our bridge did not implement the incubating api, because the noop instrument itself didn't implement it making bridging impossible. Now noop instruments implement the incubating api and so does our bridge, we call setAttributesAdvice
as was done in #11928 to verify that this works and there are no exceptions. The argument list doesn't really matter for this test and using empty list should be fine.
|
||
LongUpDownCounterBuilder upDownCounterBuilder = meter.upDownCounterBuilder("test"); | ||
assertThat(upDownCounterBuilder).isNotInstanceOf(ExtendedLongUpDownCounterBuilder.class); | ||
assertThat(upDownCounterBuilder).isInstanceOf(ExtendedLongUpDownCounterBuilder.class); | ||
((ExtendedLongUpDownCounterBuilder) upDownCounterBuilder).setAttributesAdvice(emptyList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question for the rest.
Update the OpenTelemetry SDK version to
1.42.0
.