fix and improve manifest resource provider #10857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Mar 14, 2024
...rary/src/main/java/io/opentelemetry/instrumentation/resources/AttributeResourceProvider.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Mar 14, 2024
| import java.nio.file.Path; | ||
| import java.util.Optional; | ||
|
|
||
| public class MainJarPathHolder { |
There was a problem hiding this comment.
this feels a bit more complicate than it should be, wdyt about zeitlinger#2
There was a problem hiding this comment.
that's an elegant solution indeed 😄
simplify main jar holder
laurit
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.