Update to latest otel-java snapshot #1057
Conversation
iNikem
requested review from
anuraaga,
jkwatson,
trask and
tylerbenson
as code owners
| @@ -37,6 +37,11 @@ public void add(double delta, Labels labels) { | |||
| agentDoubleCounter.add(delta, LabelBridging.toAgent(labels)); | |||
| } | |||
|
|
|||
| @Override | |||
| public void add(double v) { | |||
There was a problem hiding this comment.
Don't know how the coverage of these tests is but if it's possible to add that'd be nice. When adding these bridges I needed them to be (mostly) sure my bridging is sound. Though admittedly these seem simpler than a lot of the tracing / context related stuff.
There was a problem hiding this comment.
I am not aware of any metric-related tests in our repo. Including these bridges
There was a problem hiding this comment.
There was a problem hiding this comment.
I was unable to understand in 2 minutes how to better do that. If this is blocker, I will have to think about it tomorrow, with fresh head
There was a problem hiding this comment.
No problem to open issue(s) for anything unresolved in this PR, better to merge it sooner to resolve #1102
There was a problem hiding this comment.
Then feel free to approve and merge if build is green :)
|
I had to add a bunch of dependencies on context-propagation artifact to force gradle to take the required time-based snapshot. Without it, some unknown version was used locally. |
* Update to latest otel-java snapshot * Upgrade to working otel-java snapshot * Update to latest otel-java snapshot * Update to latest otel-java snapshot
No description provided.