Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the OpenTelemetry SDK version to 1.35.0 and remove jaeger exporter #10524

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 12, 2024

Backport of #10455 and #10241

@laurit laurit requested a review from a team February 12, 2024 12:01
@github-actions github-actions bot requested a review from theletterf February 12, 2024 12:01
@trask
Copy link
Member

trask commented Feb 13, 2024

is removing jaeger exporter necessary? would be nice not to do that in a patch release if we don't have to

@laurit
Copy link
Contributor Author

laurit commented Feb 13, 2024

is removing jaeger exporter necessary? would be nice not to do that in a patch release if we don't have to

Jaeger exporter was removed from sdk. That leaves us the following options

  • remove jaeger
  • not update sdk
  • include the latest jaeger exporter and hope that it works with the latest sdk

@trask
Copy link
Member

trask commented Feb 13, 2024

I think my preference would be to not update the SDK in that case.

@jack-berg @jkwatson any thoughts? thanks

@jkwatson
Copy link
Contributor

I think my preference would be to not update the SDK in that case.

@jack-berg @jkwatson any thoughts? thanks

No opinion from me. I don't use the agent, and now I don't use the Jaeger exporters, either. ;)

@trask
Copy link
Member

trask commented Feb 13, 2024

another option would be to bump the version to 1.36.0 (creating a new release/v1.36.x branch)

@jack-berg
Copy link
Member

Creating new 1.x release branches which mirror opentelemetry-java releases is interesting..

I'm also open to publishing patch releases for 1.34.x for security vulnerabilities until instrumentation's support for 1.x ends. I recall that semconv requires >= 6 months of support. Is there a specific support time period in mind for 1.x?

@trask
Copy link
Member

trask commented Feb 13, 2024

another option would be to bump the version to 1.36.0 (creating a new release/v1.36.x branch)

oops, I meant 1.33.0 (creating a new release/v1.33.x branch)

@trask
Copy link
Member

trask commented Feb 13, 2024

I recall that semconv requires >= 6 months of support. Is there a specific support time period in mind for 1.x?

I think we're open to security patching 1.x for longer than 6 months if there's demand

@trask trask changed the base branch from release/v1.32.x to release/v1.33.x February 27, 2024 20:50
@trask
Copy link
Member

trask commented Feb 27, 2024

I re-targeted this to the new release/v1.33.x branch

@laurit laurit merged commit 6e7c138 into open-telemetry:release/v1.33.x Feb 28, 2024
47 checks passed
@laurit laurit deleted the update-opentelemetry-sdk-to-1.35.0 branch February 28, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants