Skip to content

Commit

Permalink
Fix docker login on Windows (#2573)
Browse files Browse the repository at this point in the history
* Fix docker login on Windows

* Add TODO
  • Loading branch information
iNikem authored Mar 15, 2021
1 parent 5bd148c commit 196d1b3
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/build-test-matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,8 @@ jobs:
job-id: matrix-smoke

- name: Login to GitHub Package Registry
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GHCR_TOKEN }}
#TODO replace with docker-login action when https://github.com/docker/login-action/issues/47
run: echo ${{ secrets.GHCR_TOKEN }} | docker login ghcr.io -u ${{ github.repository_owner }} --password-stdin

- name: Build Docker Image
run: |
Expand Down

0 comments on commit 196d1b3

Please sign in to comment.