Disk buffering api changes#2084
Merged
trask merged 11 commits intoopen-telemetry:mainfrom Aug 19, 2025
Merged
Conversation
MustafaHaddara
approved these changes
Aug 12, 2025
breedx-splk
reviewed
Aug 15, 2025
...fering/src/main/java/io/opentelemetry/contrib/disk/buffering/exporters/ExporterCallback.java
Show resolved
Hide resolved
breedx-splk
reviewed
Aug 15, 2025
| if (operation.isSuccessful()) { | ||
| callback.onExportSuccess(type); | ||
| return CompletableResultCode.ofSuccess(); | ||
| } else { |
Contributor
There was a problem hiding this comment.
prefer removing the redundant else and unindenting the part below it.
Contributor
Author
There was a problem hiding this comment.
Good point, I've added the changes.
breedx-splk
reviewed
Aug 15, 2025
| private final Duration writeTimeout; | ||
| private final SignalType type; | ||
|
|
||
| public SignalStorageExporter( |
Contributor
There was a problem hiding this comment.
Would be good to have unit test coverage for this new class.
Contributor
Author
There was a problem hiding this comment.
I've just added unit tests for it.
breedx-splk
reviewed
Aug 15, 2025
.../src/main/java/io/opentelemetry/contrib/disk/buffering/internal/storage/FileSpanStorage.java
Show resolved
Hide resolved
breedx-splk
reviewed
Aug 15, 2025
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Looks good overall, just a few small comments. Thanks!
breedx-splk
approved these changes
Aug 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
tylerbenson
reviewed
Aug 27, 2025
|
|
||
| package io.opentelemetry.contrib.disk.buffering; | ||
|
|
||
| public enum SignalType { |
Member
There was a problem hiding this comment.
@LikeTheSalad Any reason you added this instead of using io.opentelemetry.contrib.disk.buffering.internal.utils.SignalTypes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are meant to address the feedback received since the creation of this module, as well as prepare it to get promoted from alpha status to beta, as mentioned here.
The key takeaways for this new API are the following:
The plan is to create a default implementation for the new API that covers the existing API's behavior. Since migrating the existing behavior to the new API will require changing many files, I've decided to leave it for a follow-up PR, so that we can focus on the new API design on this one.