ci: use GITHUB_TOKEN for chart update branch pushes#2154
Merged
Conversation
MrAlias
changed the title
MrAlias
force-pushed
the
auto-up-fix-pr-perms
branch
from
fba672d to
4b5579f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the reusable “update chart app version” workflow to push update branches using the repository-scoped GITHUB_TOKEN, while continuing to use the OTelBot GitHub App token only for creating/updating the PR so downstream workflows still run.
Changes:
- Stop using the OTelBot token for checkout and branch pushes; disable persisted checkout credentials.
- Push the update branch using
secrets.GITHUB_TOKEN. - Create the OTelBot app token only for PR create/edit operations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TylerHelmuth
approved these changes
Apr 27, 2026
Member
|
@MrAlias is this PR ready to merge or do we need to wait on open-telemetry/community#3376? |
Contributor
Author
|
Sorry about the delay. This is ready to merge. It was confirmed in that issues this approach should be correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the chart update workflow to use
GITHUB_TOKENfor pushing the update branch and to use the OTelBot app token only for creating or updating the pull request.What changed
secrets.GITHUB_TOKENWhy
The update chart workflows were failing when the workflow tried to push with the OTelBot token:
Splitting the push and PR steps avoids using the OTelBot token for the repository write that was failing, while still using OTelBot for the PR itself.