fix(operator): use toYaml for VPA controlledResources#2144
Merged
dmitryax merged 2 commits intoApr 11, 2026
Merged
Conversation
controlledResources was rendered inline without toYaml, producing invalid YAML output (e.g. `[cpu memory]` instead of a proper list). Use toYaml | nindent to match the pattern used by the other fields in the same template.
LaikaN57
force-pushed
the
fix/operator-vpa-controlled-resources-toyaml
branch
from
9c1ae43 to
7915f11
Compare
Member
|
@LaikaN57 Thanks for the fix. Please bump the chart's version |
Contributor
Author
dmitryax
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controlledResourcesin the VPA template was rendered inline withouttoYaml, producing invalid YAML output (e.g.controlledResources: [cpu memory]instead of a proper YAML list)toYaml | nindentto match the pattern used by the other fields (recommenders,maxAllowed,minAllowed) in the same template