[opentelemetry-collector]: custom apiVersion support#2050
Merged
Conversation
medzin
requested review from
a team,
TylerHelmuth,
dmitryax and
povilasv
as code owners
medzin
changed the title
TylerHelmuth
reviewed
Apr 9, 2026
Member
TylerHelmuth
left a comment
TylerHelmuth
left a comment
There was a problem hiding this comment.
Left some feedback on how we can make the implementation simpler. Also please remove the new examples as the new field is straightforward.
medzin
force-pushed
the
main
branch
4 times, most recently
from
c7595a2 to
5c52829
Compare
Contributor
Author
|
@TylerHelmuth removed examples and simplified the code. |
TylerHelmuth
approved these changes
Apr 10, 2026
Adds configurable apiVersion and extra updateStrategy fields for DaemonSet mode. This enables: - Using custom controllers like OpenKruise Advanced DaemonSet - Partition-based rollouts for safer canary deployments - In-place pod updates without recreation - Testing new API versions before they become stable Includes example and CI values for OpenKruise configuration.
Move .Values.daemonset.apiVersion to .Values.apiVersion so it applies uniformly to daemonset, deployment, and statefulset modes.
…nd rollingUpdate support
… update daemonset-openkruise
…e openkruise examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configurable apiVersion and extra updateStrategy fields for DaemonSet/StatefulSet/Deployment mode. This enables: