Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deadcode, and confusing sampler interface from API #999

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Remove deadcode, and confusing sampler interface from API #999

merged 3 commits into from
Jul 30, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 30, 2020 •
edited
Loading

MrAlias
MrAlias approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting. Thanks for the catch!

For those also wondering, this is an SDK concern and is all plumbed in there.

@MrAlias MrAlias merged commit 4b96967 into open-telemetry:master Jul 30, 2020
@bogdandrutu bogdandrutu deleted the samplerapi branch July 30, 2020 23:49
@Aneurysm9 Aneurysm9 mentioned this pull request Aug 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@MrAlias MrAlias MrAlias approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @Aneurysm9 @MrAlias