Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testtrace.Span tracks and returns its SpanKind. #987

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

purple4reina
Copy link
Contributor

This pull request makes it possible to test the SpanKind of a testtrace.Span.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 29, 2020

CLA Check
The committers are authorized under a signed CLA.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. Can we add the addition to the Changelog?

@open-telemetry open-telemetry deleted a comment from purple4reina Jul 29, 2020
@MrAlias MrAlias merged commit fa883d4 into open-telemetry:master Jul 29, 2020
@MrAlias MrAlias mentioned this pull request Jul 29, 2020
@purple4reina purple4reina deleted the test-spankind branch July 30, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants