Skip to content

attribute: add Value.String() and deprecate Emit; update usages#8154

Closed
sonalgaud12 wants to merge 2 commits intoopen-telemetry:mainfrom
sonalgaud12:attribute.Value.String
Closed

attribute: add Value.String() and deprecate Emit; update usages#8154
sonalgaud12 wants to merge 2 commits intoopen-telemetry:mainfrom
sonalgaud12:attribute.Value.String

Conversation

@sonalgaud12
Copy link
Copy Markdown

#8144

Add String() string to attribute.Value implementing fmt.Stringer, with the same output as Emit(). Deprecate Emit in favor of String. Update go.opentelemetry.io/otel/exporters/prometheus to use Value.String() instead of Value.Emit().

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.7%. Comparing base (3b18b21) to head (8031d15).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8154     +/-   ##
=======================================
+ Coverage   81.8%   82.7%   +0.9%     
=======================================
  Files        308     308             
  Lines      23801   28511   +4710     
=======================================
+ Hits       19482   23600   +4118     
- Misses      3942    4534    +592     
  Partials     377     377             
Files with missing lines Coverage Δ
attribute/value.go 91.7% <100.0%> (-1.0%) ⬇️
exporters/prometheus/exporter.go 90.8% <100.0%> (+<0.1%) ⬆️

... and 260 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is blocked by #8142.

@sonalgaud12 sonalgaud12 closed this Apr 8, 2026
@sonalgaud12
Copy link
Copy Markdown
Author

@pellared Closed it for now

@sonalgaud12 sonalgaud12 reopened this Apr 9, 2026
@sonalgaud12 sonalgaud12 closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants