Skip to content

sdk/resource: add WithContext variants for Default and Environment (#7808)#8051

Merged
dmathieu merged 6 commits intoopen-telemetry:mainfrom
ajuijas:feature/plumb-context-env-7808
Mar 17, 2026
Merged

sdk/resource: add WithContext variants for Default and Environment (#7808)#8051
dmathieu merged 6 commits intoopen-telemetry:mainfrom
ajuijas:feature/plumb-context-env-7808

Conversation

@ajuijas
Copy link
Copy Markdown
Contributor

@ajuijas ajuijas commented Mar 12, 2026 •
edited
Loading

Description

Address issue #7808 by plumbing context.Context through resource.Environment and resource.Default.

Currently, these functions hardcode context.Background(), which prevents detectors (especially those that might perform network lookups or OS calls) from respecting timeouts or cancellations provided by the caller.

Changes

  • Adds EnvironmentWithContext(ctx context.Context) as a new public function.
  • Adds DefaultWithContext(ctx context.Context) as a new public function.
  • Maintains backward compatibility by making Environment() and Default() thin wrappers around the new WithContext variants.

Testing

  • Added unit tests in sdk/resource/resource_test.go to verify the new functions.
  • Verified that all sdk/resource tests pass.
  • Verified that make golangci-lint passes repository-wide.

Fixes #7808

@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Mar 12, 2026

This needs a changelog entry.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.6%. Comparing base (08efeb4) to head (9a679ad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8051   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        304     304           
  Lines      23448   23452    +4     
=====================================
+ Hits       19138   19143    +5     
+ Misses      3928    3927    -1     
  Partials     382     382
Files with missing lines Coverage Δ
sdk/resource/resource.go 80.8% <100.0%> (+0.6%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

flc1125
flc1125 reviewed Mar 12, 2026
View reviewed changes
@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Mar 13, 2026

This will need changelog entries.

@ajuijas ajuijas force-pushed the feature/plumb-context-env-7808 branch from abc363b to d530f01 Compare March 13, 2026 09:06
dmathieu
dmathieu approved these changes Mar 13, 2026
View reviewed changes
@dmathieu dmathieu merged commit d5f403c into open-telemetry:main Mar 17, 2026
33 checks passed
@pellared pellared added this to the v1.43.0 milestone Apr 1, 2026
@dmathieu dmathieu mentioned this pull request Apr 2, 2026
Merged
dmathieu added a commit that referenced this pull request Apr 3, 2026
@dmathieu @MrAlias
Release v1.43.0 / v0.65.0 / v0.19.0 (#8128)
9276201 
Release issue:
#8127

## Added

- Add `IsRandom` and `WithRandom` on `TraceFlags`, and `IsRandom` on
`SpanContext` in `go.opentelemetry.io/otel/trace`
for [W3C Trace Context Level 2 Random Trace ID
Flag](https://www.w3.org/TR/trace-context-2/#random-trace-id-flag)
support. (#8012)
- Add service detection with `WithService` in
`go.opentelemetry.io/otel/sdk/resource`. (#7642)
- Add `DefaultWithContext` and `EnvironmentWithContext` in
`go.opentelemetry.io/otel/sdk/resource` to support plumbing
`context.Context` through default and environment detectors. (#8051)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`.
(#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8038)
- Support attributes with empty value (`attribute.EMPTY`) in
`go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest`. (#8038)
- Add support for per-series start time tracking for cumulative metrics
in `go.opentelemetry.io/otel/sdk/metric`.
  Set `OTEL_GO_X_PER_SERIES_START_TIMESTAMPS=true` to enable. (#8060)
- Add `WithCardinalityLimitSelector` for metric reader for configuring
cardinality limits specific to the instrument kind. (#7855)

## Changed

- Introduce the `EMPTY` Type in `go.opentelemetry.io/otel/attribute` to
reflect that an empty value is now a valid value, with `INVALID`
remaining as a deprecated alias of `EMPTY`. (#8038)
- Refactor slice handling in `go.opentelemetry.io/otel/attribute` to
optimize short slice values with fixed-size fast paths. (#8039)
- Improve performance of span metric recording in
`go.opentelemetry.io/otel/sdk/trace` by returning early if
self-observability is not enabled. (#8067)
- Improve formatting of metric data diffs in
`go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest`. (#8073)

## Deprecated

- Deprecate `INVALID` in `go.opentelemetry.io/otel/attribute`. Use
`EMPTY` instead. (#8038)

## Fixed

- Return spec-compliant `TraceIdRatioBased` description. This is a
breaking behavioral change, but it is necessary to
make the implementation
[spec-compliant](https://opentelemetry.io/docs/specs/otel/trace/sdk/#traceidratiobased).
(#8027)
- Fix a race condition in `go.opentelemetry.io/otel/sdk/metric` where
the lastvalue aggregation could collect the value 0 even when no
zero-value measurements were recorded. (#8056)
- Limit HTTP response body to 4 MiB in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` to
mitigate excessive memory usage caused by a misconfigured or malicious
server.
Responses exceeding the limit are treated as non-retryable errors.
(#8108)
- Limit HTTP response body to 4 MiB in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` to
mitigate excessive memory usage caused by a misconfigured or malicious
server.
Responses exceeding the limit are treated as non-retryable errors.
(#8108)
- Limit HTTP response body to 4 MiB in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` to
mitigate excessive memory usage caused by a misconfigured or malicious
server.
Responses exceeding the limit are treated as non-retryable errors.
(#8108)
- `WithHostID` detector in `go.opentelemetry.io/otel/sdk/resource` to
use full path for `kenv` command on BSD. (#8113)
- Fix missing `request.GetBody` in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` to
correctly handle HTTP2 GOAWAY frame. (#8096)

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flc1125 flc1125 flc1125 left review comments

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.43.0

Development

Successfully merging this pull request may close these issues.

Plumb context.Context through resource.Environment

5 participants

@ajuijas @dmathieu @dashpole @flc1125 @pellared