Skip to content

Semconv metric helper caller-slice mutation fix #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pellared merged 2 commits into from
Mar 4, 2026
Merged

Semconv metric helper caller-slice mutation fix #7993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d153e
Do not mutate passed attrs in metric gen pkgs
MrAlias Mar 3, 2026
9f707e8
Merge branch 'main' into semconv-metric-attr
pellared Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion semconv/templates/registry/go/instrument.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Int64
{{ prefix }}metric.WithAttributes(
{%- if attrs | required | length > 0 %}
{{ prefix }} append(
{{ prefix }} attrs,
{{ prefix }} attrs[:len(attrs):len(attrs)],
{%- for attr in attrs | required | attribute_sort %}
Comment thread
MrAlias marked this conversation as resolved.
{{ prefix }} {{ to_attribute(attr, pkg) }}
{%- endfor %}
Expand Down
2 changes: 1 addition & 1 deletion semconv/v1.40.0/azureconv/metric.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions semconv/v1.40.0/cicdconv/metric.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions semconv/v1.40.0/dbconv/metric.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion semconv/v1.40.0/dnsconv/metric.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions semconv/v1.40.0/genaiconv/metric.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions semconv/v1.40.0/httpconv/metric.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading