sdk/log/observ: guard LogProcessed with Enabled#7848
Merged
MrAlias merged 4 commits intoopen-telemetry:mainfrom Feb 3, 2026
Merged
sdk/log/observ: guard LogProcessed with Enabled#7848MrAlias merged 4 commits intoopen-telemetry:mainfrom
MrAlias merged 4 commits intoopen-telemetry:mainfrom
Conversation
pellared
approved these changes
Jan 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7848 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 304 304
Lines 23235 23236 +1
=====================================
+ Hits 18993 18995 +2
+ Misses 3860 3858 -2
- Partials 382 383 +1
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Jan 29, 2026
16 tasks
MrAlias
approved these changes
Feb 3, 2026
dmathieu
added a commit
that referenced
this pull request
Mar 18, 2026
#8067) Guards SpanStarted and spanLive with Enabled(ctx) to avoid building metric options/attributes when instruments are disabled. ``` BenchmarkTracer (noop MeterProvider): SpanStarted: ~1.77 ns/op -> ~0.48 ns/op (~3.7x) SpanLive: ~2.05 ns/op -> ~0.52 ns/op (~3.9x) SpanEnded: ~2.05 ns/op -> ~0.52 ns/op (~3.9x) ``` No behavior change when enabled; existing tests cover enabled path. ~~No CHANGELOG entry, following #7848.~~ Issue: #7800 --------- Co-authored-by: Damien Mathieu <42@dmathieu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guards SLP.LogProcessed with processed.Enabled(ctx) to avoid building metric
options/attributes when the processed counter is disabled.
BenchmarkSLP (noop MeterProvider):
LogProcessedWithError: ~106 ns/op, 232 B/op, 3 allocs/op -> ~0.46 ns/op, 0 B/op, 0 allocs/op
No behavior change when enabled; existing tests cover enabled path.
I don't believe this is a "notable" change, so doesn't need a CHANGELOG entry.
Issue: #7800