Skip to content

address feedback from #7478 #7718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dashpole merged 1 commit into from
Dec 16, 2025
+3 −3
Merged

address feedback from #7478 #7718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/metric/internal/aggregate/lastvalue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type lastValuePoint[N int64 | float64] struct {
res FilteredExemplarReservoir[N]
}

// lastValue summarizes a set of measurements as the last one made.
// lastValueMap summarizes a set of measurements as the last one made.
type lastValueMap[N int64 | float64] struct {
newRes func(attribute.Set) FilteredExemplarReservoir[N]
values limitedSyncMap
Expand Down Expand Up @@ -98,7 +98,7 @@ func (s *deltaLastValue[N]) copyAndClearDpts(
t time.Time,
) int {
// Ignore if dest is not a metricdata.Gauge. The chance for memory reuse of
// the lastValuePoints is missed (better luck next time).
// the DataPoints is missed (better luck next time).
gData, _ := (*dest).(metricdata.Gauge[N])
// delta always clears values on collection
readIdx := s.hcwg.swapHotAndWait()
Expand All @@ -122,7 +122,7 @@ func (s *deltaLastValue[N]) copyAndClearDpts(
// Do not report stale values.
s.hotColdValMap[readIdx].values.Clear()
*dest = gData
return n
return i
}

// cumulativeLastValue summarizes a set of measurements as the last one made.
Expand Down
Loading