PoC: allow reservoirs to defer recording the timestamp until storage#7711
Closed
dashpole wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
PoC: allow reservoirs to defer recording the timestamp until storage#7711dashpole wants to merge 1 commit intoopen-telemetry:mainfrom
dashpole wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7711 +/- ##
=======================================
- Coverage 86.2% 86.2% -0.1%
=======================================
Files 302 302
Lines 21971 21977 +6
=======================================
+ Hits 18950 18954 +4
- Misses 2640 2642 +2
Partials 381 381
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recording the current time can be expensive, so I thought maybe deferring it until after the time-weighted algorithm decided to store it would have a positive impact on performance. But in my testing, it is less than a 1% improvement, which i'm not sure is worth the additional complexity:
Benchmarks are both after #7447 is applied.