Fix package name documentation and missing copyright in semconv/v1.34.0#7657
Merged
MrAlias merged 6 commits intoopen-telemetry:mainfrom Dec 5, 2025
Merged
Fix package name documentation and missing copyright in semconv/v1.34.0#7657MrAlias merged 6 commits intoopen-telemetry:mainfrom
semconv/v1.34.0#7657MrAlias merged 6 commits intoopen-telemetry:mainfrom
Conversation
MrAlias
added
documentation
dashpole
approved these changes
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects documentation errors in generated semantic convention files for v1.34.0 by fixing incorrect package name references and adding missing copyright headers.
- Corrected package documentation comments that incorrectly referenced "httpconv" to use the actual package name
- Added missing copyright and license headers following the "Code generated" comment
- Ensured consistency with the copyright header format used in other semantic convention versions
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| semconv/v1.34.0/vcsconv/metric.go | Fixed package doc from "httpconv" to "vcsconv", added copyright header |
| semconv/v1.34.0/systemconv/metric.go | Fixed package doc from "httpconv" to "systemconv", added copyright header |
| semconv/v1.34.0/signalrconv/metric.go | Fixed package doc from "httpconv" to "signalrconv", added copyright header |
| semconv/v1.34.0/rpcconv/metric.go | Fixed package doc from "httpconv" to "rpcconv", added copyright header |
| semconv/v1.34.0/processconv/metric.go | Fixed package doc from "httpconv" to "processconv", added copyright header |
| semconv/v1.34.0/otelconv/metric.go | Fixed package doc from "httpconv" to "otelconv", added copyright header |
| semconv/v1.34.0/messagingconv/metric.go | Fixed package doc from "httpconv" to "messagingconv", added copyright header |
| semconv/v1.34.0/k8sconv/metric.go | Fixed package doc from "httpconv" to "k8sconv", added copyright header |
| semconv/v1.34.0/hwconv/metric.go | Fixed package doc from "httpconv" to "hwconv", added copyright header |
| semconv/v1.34.0/httpconv/metric.go | Added missing copyright header (package doc was already correct) |
| semconv/v1.34.0/goconv/metric.go | Fixed package doc from "httpconv" to "goconv", added copyright header |
| semconv/v1.34.0/genaiconv/metric.go | Fixed package doc from "httpconv" to "genaiconv", added copyright header |
| semconv/v1.34.0/faasconv/metric.go | Fixed package doc from "httpconv" to "faasconv", added copyright header |
| semconv/v1.34.0/dnsconv/metric.go | Fixed package doc from "httpconv" to "dnsconv", added copyright header |
| semconv/v1.34.0/dbconv/metric.go | Fixed package doc from "httpconv" to "dbconv", added copyright header |
| semconv/v1.34.0/cpuconv/metric.go | Fixed package doc from "httpconv" to "cpuconv", added copyright header |
| semconv/v1.34.0/containerconv/metric.go | Fixed package doc from "httpconv" to "containerconv", added copyright header |
| semconv/v1.34.0/cicdconv/metric.go | Fixed package doc from "httpconv" to "cicdconv", added copyright header |
| semconv/v1.34.0/azureconv/metric.go | Fixed package doc from "httpconv" to "azureconv", added copyright header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmathieu
approved these changes
Dec 4, 2025
XSAM
approved these changes
Dec 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7657 +/- ##
=======================================
- Coverage 86.1% 86.1% -0.1%
=======================================
Files 298 298
Lines 21709 21709
=======================================
- Hits 18705 18704 -1
- Misses 2627 2628 +1
Partials 377 377 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified in the review of #7648