-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use []float64 for histogram boundaries, not []metric.Number #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizthegrey
approved these changes
May 21, 2020
MrAlias
reviewed
May 21, 2020
MrAlias
reviewed
May 21, 2020
MrAlias
reviewed
May 21, 2020
CURRENT:
WITH BINARY SEARCH:
|
MrAlias
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Aneurysm9
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading through the histogram aggregator was confusing because the boundaries are specified as []metric.Number, but despite this were expected to be floating point numbers. This makes the boundaries []float, which is less confusing.
This also adds a benchmark. I considered whether binary search outperforms linear search in any practical-sized histogram, and the answer is no. Binary search beats linear search for histograms sized >= 256 to 512 elements.
Resolves #534.
Resolves #759.