-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable parts of batch_span_processor test as flakes #743
Conversation
@vmihailenco It turns out we didn't fix the flakes last time. I did two things here, one was to eliminate the leaked goroutine to throw-away spans (using the wait group), two was to wait for the drain to finish to ensure the test doesn't race with draining the queue. |
I believe it has the same problem you've indicated previously - close(bsp.stopCh)
// Here processQueue can receive on stopCh and execute bsp.stopWait.Done()
// Then bsp.stopWait can be 0 at this point and Wait can panic.
bsp.stopWait.Wait() What is worse
As a result we spend hours trying to write "good" code and still have this monster. And I believe it is still not 100% correct. TBH I would just add |
The defer/recover addresses the safety issue, I think, but the test is forcing this "monster" as you call it. I'm ready to disable this test. |
@vmihailenco Thanks for your help. I think this is an improvement and that we can postpone a proper test. |
This:
Part of #741.