Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Measure instrument by ValueRecorder instrument #732

Merged
merged 5 commits into from
May 16, 2020

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented May 15, 2020

This renames "Measure" to "ValueRecorder" and updates some of the doc comments, removing a lot of stale content.

Part of #729.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

example/prometheus/main.go Outdated Show resolved Hide resolved
example/prometheus/main.go Outdated Show resolved Hide resolved
sdk/metric/doc.go Outdated Show resolved Hide resolved
sdk/metric/doc.go Outdated Show resolved Hide resolved
@jmacd jmacd merged commit 6bc14ff into open-telemetry:master May 16, 2020
@jmacd jmacd deleted the jmacd/newinst branch May 16, 2020 05:11
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants