Skip to content

Add tests for attribute JSON marshalling #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2025
Merged

Add tests for attribute JSON marshalling #7268

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5fff54
add tests for attribute JSON marshalling
dashpole Aug 28, 2025
beb3a07
Update attribute/set_test.go
dashpole Aug 28, 2025
0d87937
Merge branch 'main' into json_marshal_test
dashpole Aug 29, 2025
a605c38
Update attribute/set_test.go
dashpole Aug 29, 2025
e6c5f5c
Merge branch 'main' into json_marshal_test
MrAlias Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 127 additions & 0 deletions attribute/set_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,133 @@ func args(m reflect.Method) []reflect.Value {
return out
}

func TestMarshalJSON(t *testing.T) {
for _, tc := range []struct {
desc string
kvs []attribute.KeyValue
wantJSON string
}{
{
desc: "empty",
kvs: []attribute.KeyValue{},
wantJSON: `[]`,
},
{
desc: "single string attribute",
kvs: []attribute.KeyValue{attribute.String("A", "a")},
wantJSON: `[{"Key":"A","Value":{"Type":"STRING","Value":"a"}}]`,
},
{
desc: "many mixed attributes",
kvs: []attribute.KeyValue{
attribute.Bool("A", true),
attribute.BoolSlice("B", []bool{true, false}),
attribute.Int("C", 1),
attribute.IntSlice("D", []int{2, 3}),
attribute.Int64("E", 22),
attribute.Int64Slice("F", []int64{33, 44}),
attribute.Float64("G", 1.1),
attribute.Float64Slice("H", []float64{2.2, 3.3}),
attribute.String("I", "Z"),
attribute.StringSlice("J", []string{"X", "Y"}),
attribute.Stringer("K", &simpleStringer{val: "foo"}),
},
wantJSON: `[
{
"Key": "A",
"Value": {
"Type": "BOOL",
"Value": true
}
},
{
"Key": "B",
"Value": {
"Type": "BOOLSLICE",
"Value": [true, false]
}
},
{
"Key": "C",
"Value": {
"Type": "INT64",
"Value": 1
}
},
{
"Key": "D",
"Value": {
"Type": "INT64SLICE",
"Value": [2, 3]
}
},
{
"Key": "E",
"Value": {
"Type": "INT64",
"Value": 22
}
},
{
"Key": "F",
"Value": {
"Type": "INT64SLICE",
"Value": [33, 44]
}
},
{
"Key": "G",
"Value": {
"Type": "FLOAT64",
"Value": 1.1
}
},
{
"Key": "H",
"Value": {
"Type": "FLOAT64SLICE",
"Value": [2.2, 3.3]
}
},
{
"Key": "I",
"Value": {
"Type": "STRING",
"Value": "Z"
}
},
{
"Key": "J",
"Value": {
"Type": "STRINGSLICE",
"Value": ["X", "Y"]
}
},
{
"Key": "K",
"Value": {
"Type": "STRING",
"Value": "foo"
}
}
]`,
},
} {
t.Run(tc.desc, func(t *testing.T) {
set := attribute.NewSet(tc.kvs...)
by, err := set.MarshalJSON()
require.NoError(t, err)
assert.JSONEq(t, tc.wantJSON, string(by))
})
}
}

type simpleStringer struct {
val string
}

func (s *simpleStringer) String() string { return s.val }

func BenchmarkFiltering(b *testing.B) {
var kvs [26]attribute.KeyValue
buf := [1]byte{'A' - 1}
Expand Down
Loading