Skip to content

sdk/trace: trace id high 64 bit tests #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmathieu merged 10 commits into from
Oct 6, 2025
Merged

sdk/trace: trace id high 64 bit tests #7212

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c47998b
modify TestWithIDGenerator to test for low & high bits of trace id
mahendrabishnoi2 Aug 16, 2025
1d1ac41
add explicit types for constant as values are higher that what int ca…
mahendrabishnoi2 Aug 16, 2025
9063295
ubuntu compat: explicit type conversion
mahendrabishnoi2 Aug 16, 2025
db68151
Merge branch 'main' into chore/trace-id-generator-test
mahendrabishnoi2 Aug 28, 2025
e0eb91e
Merge branch 'main' into chore/trace-id-generator-test
mahendrabishnoi2 Sep 13, 2025
e87787e
Merge branch 'main' into chore/trace-id-generator-test
mahendrabishnoi2 Sep 27, 2025
7b2b8da
Update sdk/trace/trace_test.go
dmathieu Oct 6, 2025
f6a3b90
Update sdk/trace/trace_test.go
dmathieu Oct 6, 2025
825b779
Merge branch 'main' into chore/trace-id-generator-test
dmathieu Oct 6, 2025
0b3b276
fix renamed variables
dmathieu Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions sdk/trace/trace_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1931,14 +1931,15 @@ func TestSamplerTraceState(t *testing.T) {
}

type testIDGenerator struct {
traceID uint64
spanID uint64
traceIDHigh uint64
traceIDLow uint64
spanID uint64
}

func (gen *testIDGenerator) NewIDs(ctx context.Context) (trace.TraceID, trace.SpanID) {
traceIDHex := fmt.Sprintf("%032x", gen.traceID)
traceIDHex := fmt.Sprintf("%016x%016x", gen.traceIDHigh, gen.traceIDLow)
traceID, _ := trace.TraceIDFromHex(traceIDHex)
gen.traceID++
gen.traceIDLow++

spanID := gen.NewSpanID(ctx, traceID)
return traceID, spanID
Expand All @@ -1955,12 +1956,13 @@ var _ IDGenerator = (*testIDGenerator)(nil)

func TestWithIDGenerator(t *testing.T) {
const (
startTraceID = 0x1001_1001_1001_1001
startSpanID = 0x2001_2001_2001_2001
numSpan = 5
startTraceIDHigh uint64 = 0x1001_1001_1001_1001
startTraceIDLow uint64 = 0x2002_2002_2002_2002
startSpanID uint64 = 0x3003_3003_3003_3003
numSpan = 5
)

gen := &testIDGenerator{traceID: startTraceID, spanID: startSpanID}
gen := &testIDGenerator{traceIDHigh: startTraceIDHigh, traceIDLow: startTraceIDLow, spanID: startSpanID}
te := NewTestExporter()
tp := NewTracerProvider(
WithSyncer(te),
Expand All @@ -1973,11 +1975,19 @@ func TestWithIDGenerator(t *testing.T) {

gotSpanID, err := strconv.ParseUint(span.SpanContext().SpanID().String(), 16, 64)
require.NoError(t, err)
assert.Equal(t, uint64(startSpanID)+uint64(i), gotSpanID)
assert.Equal(t, startSpanID+uint64(i), gotSpanID)

gotTraceID, err := strconv.ParseUint(span.SpanContext().TraceID().String(), 16, 64)
require.NoError(t, err)
assert.Equal(t, uint64(startTraceID)+uint64(i), gotTraceID)
traceIdStr := span.SpanContext().TraceID().String()
highBitsStr := traceIdStr[:16]
lowBitsStr := traceIdStr[16:]

traceIdValidator := func(t *testing.T, id string, expected uint64) {
gotTraceID, err := strconv.ParseUint(id, 16, 64)
require.NoError(t, err)
assert.Equal(t, expected, gotTraceID)
}
traceIdValidator(t, highBitsStr, startTraceIDHigh)
traceIdValidator(t, lowBitsStr, startTraceIDLow+uint64(i))
}()
}
}
Expand Down