Retract most recent prometheus exporter release#7046
Retract most recent prometheus exporter release#7046dashpole merged 2 commits intoopen-telemetry:mainfrom
Conversation
dashpole
requested review from
MrAlias,
XSAM,
dmathieu and
pellared
as code owners
|
Is the fix for the issue going to be included in the release that retracts this? Or, are you planning to retract the release that makes this retraction as well? |
|
The fix will be included in the release. Fix: #7044 |
|
Should we add a changelog entry? |
Will releasing this in a week or two be soon enough, or does this need to be released as a sooner patch release for this module? |
|
I think the collector folks would like the fix sooner, as it is a fairly large regression for their self-observability metrics. But we might want to wait for the cardinality limit implementation to land? Or revert the new public function? |
|
A patch release for the module would be amazing, actually, if we can do that |
Think this is possible as this module is in its own module set: opentelemetry-go/versions.yaml Lines 24 to 27 in bf570ac |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7046 +/- ##
=======================================
- Coverage 82.8% 82.8% -0.1%
=======================================
Files 261 261
Lines 24361 24361
=======================================
- Hits 20175 20171 -4
- Misses 3811 3815 +4
Partials 375 375 🚀 New features to boost your workflow:
|
Patch release for #7039 ### Changed - Retract `v0.59.0` release of `go.opentelemetry.io/otel/exporters/prometheus` module which appends incorrect unit suffixes. (#7046) - Change `go.opentelemetry.io/otel/exporters/prometheus` to no longer deduplicate suffixes when UTF8 is enabled. It is recommended to disable unit and counter suffixes in the exporter, and manually add suffixes if you rely on the existing behavior. (#7044) ### Fixed - Fix `go.opentelemetry.io/otel/exporters/prometheus` to properly handle unit suffixes when the unit is in brackets. E.g. `{spans}`. (#7044)
6 participants
Due to #7039.