left-pad 64-bit B3 trace IDs #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo and
tedsuo
as code owners
lizthegrey
approved these changes
May 5, 2020
MrAlias
approved these changes
May 5, 2020
|
sorry about the spam, editing from github web ui is annoying, but handy in a pinch |
seh
reviewed
May 5, 2020
| @@ -88,8 +88,15 @@ func (b3 B3) Extract(ctx context.Context, supplier propagation.HTTPSupplier) con | |||
| return ContextWithRemoteSpanContext(ctx, sc) | |||
| } | |||
|
|
|||
| func fixB3TID(in string) string { | |||
| if len(in) == 16 { | |||
| in = strings.Repeat("0", 16) + in | |||
There was a problem hiding this comment.
Using a const here instead of strings.Repeat would be good for a future pass. There's a lot going on in Repeat.
There was a problem hiding this comment.
Good call, I initially had strings.Repeat("0", 32-len(in)) but that failed the tests for invalid input IDs between 16 and 32 hex digits. I think it's more correct to only accept 16 or 32 hex digit values.
6 tasks
copybaranaut
pushed a commit
to pixie-io/pixie
that referenced
this pull request
May 25, 2022
Summary: OTel wants all trace ids to be 128bit. However b3 trace ids can be 64 bit. See https://github.com/openzipkin/b3-propagation#traceid-1 So we should also support propagating 64 bit trace IDs. To ensure compatibility with other OTel tooling, we left pad the trace IDs with zeroes and make it a 128 bit ID before passing it to the OTel endpoint. This mirrors the approach taken by open-telemetry/opentelemetry-go#698 Test Plan: Updated a test to use 64 bit trace ids and ensured that they get left padded with zeroes as expexted. Reviewers: nserrino, michelle, philkuz Reviewed By: philkuz JIRA Issues: PP-3407 Signed-off-by: Vihang Mehta <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D11450 GitOrigin-RevId: 9f09a7e
orishuss
pushed a commit
to orishuss/pixie
that referenced
this pull request
Jul 14, 2022
Summary: OTel wants all trace ids to be 128bit. However b3 trace ids can be 64 bit. See https://github.com/openzipkin/b3-propagation#traceid-1 So we should also support propagating 64 bit trace IDs. To ensure compatibility with other OTel tooling, we left pad the trace IDs with zeroes and make it a 128 bit ID before passing it to the OTel endpoint. This mirrors the approach taken by open-telemetry/opentelemetry-go#698 Test Plan: Updated a test to use 64 bit trace ids and ensured that they get left padded with zeroes as expexted. Reviewers: nserrino, michelle, philkuz Reviewed By: philkuz JIRA Issues: PP-3407 Signed-off-by: Vihang Mehta <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D11450 GitOrigin-RevId: 9f09a7e
orishuss
pushed a commit
to orishuss/pixie
that referenced
this pull request
Jul 14, 2022
Summary: OTel wants all trace ids to be 128bit. However b3 trace ids can be 64 bit. See https://github.com/openzipkin/b3-propagation#traceid-1 So we should also support propagating 64 bit trace IDs. To ensure compatibility with other OTel tooling, we left pad the trace IDs with zeroes and make it a 128 bit ID before passing it to the OTel endpoint. This mirrors the approach taken by open-telemetry/opentelemetry-go#698 Test Plan: Updated a test to use 64 bit trace ids and ensured that they get left padded with zeroes as expexted. Reviewers: nserrino, michelle, philkuz Reviewed By: philkuz JIRA Issues: PP-3407 Signed-off-by: Vihang Mehta <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D11450 GitOrigin-RevId: 9f09a7e
orishuss
pushed a commit
to orishuss/pixie
that referenced
this pull request
Jul 14, 2022
Summary: OTel wants all trace ids to be 128bit. However b3 trace ids can be 64 bit. See https://github.com/openzipkin/b3-propagation#traceid-1 So we should also support propagating 64 bit trace IDs. To ensure compatibility with other OTel tooling, we left pad the trace IDs with zeroes and make it a 128 bit ID before passing it to the OTel endpoint. This mirrors the approach taken by open-telemetry/opentelemetry-go#698 Test Plan: Updated a test to use 64 bit trace ids and ensured that they get left padded with zeroes as expexted. Reviewers: nserrino, michelle, philkuz Reviewed By: philkuz JIRA Issues: PP-3407 Signed-off-by: Vihang Mehta <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D11450 GitOrigin-RevId: 9f09a7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686.