-
Notifications
You must be signed in to change notification settings - Fork 1.3k
semconv: add ErrorType attribute function #6962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmathieu
merged 13 commits into
open-telemetry:main
from
bachgarash:feat/errortype-semconv-implementation
Jul 10, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
26dab19
feat: add ErrorType for semconv package 1.34.0 (#6904)
bachgarash 71fda96
feat: add test and code review fixes
bachgarash c04cd23
feat: add changelog entry
bachgarash 807ee9a
feat: table driven test and code review fixes
bachgarash ae38aa5
feat: fix test according to go standards
bachgarash 53f0efb
feat: fix lint
bachgarash b619539
Update CHANGELOG.md
bachgarash d3603c4
Update semconv/v1.34.0/error_type_test.go
bachgarash 4ee02a7
Update semconv/v1.34.0/error_type_test.go
bachgarash 049bca2
feat: improve test and update changelog
bachgarash ce47541
Update CHANGELOG.md
bachgarash c32bc4f
feat: fix typo changelog
bachgarash dd55179
Update CHANGELOG.md
bachgarash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package semconv // import "go.opentelemetry.io/otel/semconv/{{.TagVer}}" | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "reflect" | ||
|
|
||
| "go.opentelemetry.io/otel/attribute" | ||
| ) | ||
|
|
||
| // ErrorType returns an [attribute.KeyValue] identifying the error type of err. | ||
| func ErrorType(err error) attribute.KeyValue { | ||
| if err == nil { | ||
| return ErrorTypeOther | ||
| } | ||
| t := reflect.TypeOf(err) | ||
| var value string | ||
| if t.PkgPath() == "" && t.Name() == "" { | ||
| // Likely a builtin type. | ||
| value = t.String() | ||
| } else { | ||
| value = fmt.Sprintf("%s.%s", t.PkgPath(), t.Name()) | ||
| } | ||
|
|
||
| if value == "" { | ||
| return ErrorTypeOther | ||
| } | ||
| return ErrorTypeKey.String(value) | ||
| } | ||
59 changes: 59 additions & 0 deletions
59
internal/tools/semconvkit/templates/error_type_test.go.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package semconv // import "go.opentelemetry.io/otel/semconv/{{.TagVer}}" | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "go.opentelemetry.io/otel/attribute" | ||
| ) | ||
|
|
||
| type CustomError struct{} | ||
|
|
||
| func (CustomError) Error() string { | ||
| return "custom error" | ||
| } | ||
|
|
||
| func TestErrorType(t *testing.T) { | ||
| customErr := CustomError{} | ||
| builtinErr := errors.New("something went wrong") | ||
| var nilErr error | ||
|
|
||
| wantCustomType := reflect.TypeOf(customErr) | ||
| wantCustomStr := fmt.Sprintf("%s.%s", wantCustomType.PkgPath(), wantCustomType.Name()) | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| err error | ||
| want attribute.KeyValue | ||
| }{ | ||
| { | ||
| name: "BuiltinError", | ||
| err: builtinErr, | ||
| want: attribute.String("error.type", "*errors.errorString"), | ||
| }, | ||
| { | ||
| name: "CustomError", | ||
| err: customErr, | ||
| want: attribute.String("error.type", wantCustomStr), | ||
| }, | ||
| { | ||
| name: "NilError", | ||
| err: nilErr, | ||
| want: ErrorTypeOther, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| got := ErrorType(tt.err) | ||
| if got != tt.want { | ||
| t.Errorf("ErrorType(%v) = %v, want %v", tt.err, got, tt.want) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package semconv // import "go.opentelemetry.io/otel/semconv/v1.34.0" | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "reflect" | ||
|
|
||
| "go.opentelemetry.io/otel/attribute" | ||
| ) | ||
|
|
||
| // ErrorType returns an [attribute.KeyValue] identifying the error type of err. | ||
| func ErrorType(err error) attribute.KeyValue { | ||
|
bachgarash marked this conversation as resolved.
|
||
| if err == nil { | ||
| return ErrorTypeOther | ||
| } | ||
| t := reflect.TypeOf(err) | ||
| var value string | ||
| if t.PkgPath() == "" && t.Name() == "" { | ||
| // Likely a builtin type. | ||
| value = t.String() | ||
| } else { | ||
| value = fmt.Sprintf("%s.%s", t.PkgPath(), t.Name()) | ||
| } | ||
|
|
||
| if value == "" { | ||
| return ErrorTypeOther | ||
| } | ||
| return ErrorTypeKey.String(value) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package semconv // import "go.opentelemetry.io/otel/semconv/v1.34.0" | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "go.opentelemetry.io/otel/attribute" | ||
| ) | ||
|
|
||
| type CustomError struct{} | ||
|
|
||
| func (CustomError) Error() string { | ||
| return "custom error" | ||
| } | ||
|
|
||
| func TestErrorType(t *testing.T) { | ||
| customErr := CustomError{} | ||
| builtinErr := errors.New("something went wrong") | ||
| var nilErr error | ||
|
|
||
| wantCustomType := reflect.TypeOf(customErr) | ||
| wantCustomStr := fmt.Sprintf("%s.%s", wantCustomType.PkgPath(), wantCustomType.Name()) | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| err error | ||
| want attribute.KeyValue | ||
| }{ | ||
| { | ||
| name: "BuiltinError", | ||
| err: builtinErr, | ||
| want: attribute.String("error.type", "*errors.errorString"), | ||
| }, | ||
| { | ||
| name: "CustomError", | ||
| err: customErr, | ||
| want: attribute.String("error.type", wantCustomStr), | ||
| }, | ||
| { | ||
| name: "NilError", | ||
| err: nilErr, | ||
| want: ErrorTypeOther, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| got := ErrorType(tt.err) | ||
| if got != tt.want { | ||
| t.Errorf("ErrorType(%v) = %v, want %v", tt.err, got, tt.want) | ||
| } | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.