-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias api types to root #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otel.SetGlobalMeterProvider is really not much more concise than global.SetMeterProvider.
Would support this with the passthrough of Tracer, Meter, and Propagator only, or perhaps some of the key package types.
See also #295 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving cautiously. curious what other approvers think.
This looks OK to me. I would be inclined (if possible) to look at any real code (including examples) to see which can drop a substantial number of import statements as a result of this. I suspect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jmacd. I don't think it can do any harm and it should help reduce friction with some tooling, so +1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a first good step. I'm with @jmacd in seeing if this can strategically be progressed.
See #371
Fixes #371