fix(exporter/prometheus): export exemplars on native histograms#6953
fix(exporter/prometheus): export exemplars on native histograms#6953tcolgate wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6953 +/- ##
=======================================
- Coverage 82.8% 82.8% -0.1%
=======================================
Files 261 261
Lines 24312 24313 +1
=======================================
- Hits 20144 20141 -3
- Misses 3793 3797 +4
Partials 375 375
🚀 New features to boost your workflow:
|
c4355d3 to
5836c66
Compare
5836c66 to
dd61777
Compare
How so? exporters/prometheus/go.mod already lists 1.22.0, which includes the handling of exemplars on native histograms. Are there bugs? (the test I included passes, and that routes through the relevant code) |
Signed-off-by: Tristan Colgate-McFarlane <tristan@cerbos.dev>
dd61777 to
c166e90
Compare
It does not. See prometheus/client_golang#1816 (comment)
It does not seem to assert everything. See: https://github.com/open-telemetry/opentelemetry-go/pull/6772/files I think that this PR can should be closed given we already have #6772 |
The prometheus exporter had a TODO relating to adding of exemplars to exported native histogram. The upstream prometheus client has been fixed, and otel already depends on the fixed version.