Added HTTP bearer token refresh basic support#6734
Closed
corneliu-calciu wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Added HTTP bearer token refresh basic support#6734corneliu-calciu wants to merge 1 commit intoopen-telemetry:mainfrom
corneliu-calciu wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
corneliu-calciu
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu and
pellared
as code owners
The committers listed above are authorized under a signed CLA. |
Member
|
We can't accept this change. All environment variables need to be in the spec. Once it ships, #6688 will allow you to specify a custom client/transport, and do this with a custom transport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some environments all the endpoints exposed in Internet are required to have authentication.
One of the common options is to use bearer token with limited validity, as an example having one hour validity.
I added a simple change to support HTTP bearer token refresh using an environment variable: OTEL_EXPORTER_OTLP_HTTP_AUTH_BEARER_TOKEN. The token refresh mechanism is outside of the scope of this change, such mechanism will update the environment variable described above.
The changes are simple, limited and low risk.