Reimplement histogram using mutex instead of stateLocker #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move existing implementation to histogram_statelocker.go. Implement benchmarks for single thread and parallel histogram updates comparing mutex version to stateLocker version
evantorrie
requested review from
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo and
tedsuo
as code owners
krnowak
approved these changes
Apr 28, 2020
|
Want to post the benchmarks here, then drop the StateLocker-based impl? |
jmacd
approved these changes
Apr 28, 2020
|
Benchmarks: |
jmacd
approved these changes
Apr 29, 2020
evantorrie
added a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Apr 30, 2020
Fixes open-telemetry#657 With the changes in open-telemetry#667 and open-telemetry#669 to use a plain-old-mutex for concurrent access of Histogram and MinMaxSumCount aggregators, the StateLocker implementation is no longer used in the project.
jmacd
added a commit
that referenced
this pull request
Apr 30, 2020
Fixes #657 With the changes in #667 and #669 to use a plain-old-mutex for concurrent access of Histogram and MinMaxSumCount aggregators, the StateLocker implementation is no longer used in the project. Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Histogram version of #667
Unblocks #657
Move existing implementation to
histogram_statelocker.go- should be deleted before merge, but here to show performance difference.Implement benchmarks for single thread and parallel histogram updates comparing mutex version to stateLocker version.