-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk/log: Add FilterProcessor and EnabledParameters #6317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Xie <[email protected]>
Co-authored-by: Sam Xie <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6317 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 283 283
Lines 24892 24900 +8
=====================================
+ Hits 20378 20387 +9
+ Misses 4110 4109 -1
Partials 404 404 |
dashpole
approved these changes
Feb 14, 2025
XSAM
approved these changes
Feb 17, 2025
MrAlias
approved these changes
Feb 18, 2025
This was referenced Feb 21, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #6271 (comment)
There is a little overhead (IMO totally acceptable) because of data transformation. Most importantly, there is no new heap allocation.
Logger.Enabled
is still more efficient thanLogger.Emit
(benchmarks from #6315).Prior art:
I also created for tracking purposes: