Skip to content

Use archive URL for weaver registry#6235

Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom
MrAlias:weaver-archive-registry
Feb 3, 2025
Merged

Use archive URL for weaver registry#6235
MrAlias merged 3 commits intoopen-telemetry:mainfrom
MrAlias:weaver-archive-registry

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Jan 31, 2025

Resolve #6230

Instead of requiring a local copy of the semantic-conventions repository be checked out, rely on versioned archive URLs from Github.

I have verified locally this generates the expected version based on idiosyncrasies of the tagged semantic convention versions.

Instead of requiring a local copy of the semantic-conventions repo be
checked out, rely on versioned archive URLs from Github.
@MrAlias MrAlias added pkg:tooling Related to the tooling package Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jan 31, 2025
@MrAlias MrAlias added this to the v1.35.0 milestone Jan 31, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (27aaa7a) to head (92e30b8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6235     +/-   ##
=======================================
- Coverage   82.2%   82.2%   -0.1%     
=======================================
  Files        273     273             
  Lines      23744   23744             
=======================================
- Hits       19537   19536      -1     
- Misses      3858    3859      +1     
  Partials     349     349             

see 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review January 31, 2025 16:34
@MrAlias

This comment was marked as resolved.

@MrAlias MrAlias merged commit 2260929 into open-telemetry:main Feb 3, 2025
@MrAlias MrAlias deleted the weaver-archive-registry branch February 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:tooling Related to the tooling package Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure Weaver with an archive URL instead of a local clone

5 participants