Use archive URL for weaver registry#6235
Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom Feb 3, 2025
Merged
Conversation
Instead of requiring a local copy of the semantic-conventions repo be checked out, rely on versioned archive URLs from Github.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6235 +/- ##
=======================================
- Coverage 82.2% 82.2% -0.1%
=======================================
Files 273 273
Lines 23744 23744
=======================================
- Hits 19537 19536 -1
- Misses 3858 3859 +1
Partials 349 349 |
dashpole
approved these changes
Jan 31, 2025
dmathieu
approved these changes
Jan 31, 2025
XSAM
approved these changes
Jan 31, 2025
This comment was marked as resolved.
This comment was marked as resolved.
pellared
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #6230
Instead of requiring a local copy of the semantic-conventions repository be checked out, rely on versioned archive URLs from Github.
I have verified locally this generates the expected version based on idiosyncrasies of the tagged semantic convention versions.