Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Use errors.Join to unify errors #5907

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 21, 2024

Resolve #3544

Replace all custom implementations for multi-error unification with the errors.Join function of the standard library.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (1a964cc) to head (635ee88).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5907     +/-   ##
=======================================
- Coverage   84.6%   84.5%   -0.1%     
=======================================
  Files        271     271             
  Lines      22855   22822     -33     
=======================================
- Hits       19338   19305     -33     
  Misses      3172    3172             
  Partials     345     345             

see 6 files with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review October 21, 2024 18:29
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@MrAlias MrAlias merged commit 92ccad7 into open-telemetry:main Oct 22, 2024
32 checks passed
@MrAlias MrAlias deleted the multi-error branch October 22, 2024 22:10
@MrAlias MrAlias added this to the v1.32.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify mult-error handling
4 participants