-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTel logs design placeholder #4697
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4697 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 225 225
Lines 18087 18087
=======================================
- Hits 14798 14796 -2
- Misses 2992 2994 +2
Partials 297 297 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not support adding another Go module to this repository for a design doc.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not in support of adding another module or anything that would be picked up by documentation sites. This would be something that adds to the list of dead links at https://pkg.go.dev/go.opentelemetry.io/otel
This comment was marked as outdated.
This comment was marked as outdated.
I see the problem.... Someone can simply "request" even without a tag. It would be better to place it in a separate repository. |
@MadVikingGod @MrAlias Thank you 👍 |
Towards #4696
The design doc template is taken from https://github.com/golang/proposal/blob/master/design/TEMPLATE.md.