Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTel logs design placeholder #4697

Closed
wants to merge 3 commits into from

Conversation

pellared
Copy link
Member

@pellared pellared commented Nov 8, 2023

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 8, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #4697 (a3ef6a6) into main (0c5ebd5) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4697     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        225     225             
  Lines      18087   18087             
=======================================
- Hits       14798   14796      -2     
- Misses      2992    2994      +2     
  Partials     297     297             

see 1 file with indirect coverage changes

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not support adding another Go module to this repository for a design doc.

@pellared

This comment was marked as outdated.

@pellared pellared requested review from MrAlias and dashpole November 9, 2023 16:02
Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in support of adding another module or anything that would be picked up by documentation sites. This would be something that adds to the list of dead links at https://pkg.go.dev/go.opentelemetry.io/otel

@pellared

This comment was marked as outdated.

@pellared pellared requested a review from MadVikingGod November 9, 2023 16:17
@pellared
Copy link
Member Author

pellared commented Nov 9, 2023

I see the problem.... Someone can simply "request" even without a tag.

It would be better to place it in a separate repository.

@pellared pellared closed this Nov 9, 2023
@pellared
Copy link
Member Author

pellared commented Nov 9, 2023

@MadVikingGod @MrAlias Thank you 👍

@pellared pellared deleted the logs-design branch November 17, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants