-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default histogram selection in OTLP exporter #4437
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4437 +/- ##
=====================================
Coverage 78.8% 78.8%
=====================================
Files 253 253
Lines 20630 20668 +38
=====================================
+ Hits 16267 16307 +40
+ Misses 4014 4012 -2
Partials 349 349
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I haven't been reviewing lately, but see that we're using gotmpl for this repetitive code between otlpmetric{grpc,http}. Looks like this is the outcome of #3846.
I think many of the language SDKs have similar issues.
Resolve #4422
If a user sets the
OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION
tobase2_exponential_bucket_histogram
(case-insensitive) the default base-2 exponential histogram should be used for the exporter selector in both OTLP metric exporters.