Detect duplicate instruments for case-insensitive names #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve open-telemetry#3835 Detect duplicate instrument registrations for instruments that have the same case-insensitive names. Continue to return the instruments with different names, but log a warning. This is the solution proposed in open-telemetry/opentelemetry-specification#3606.
MrAlias
added
pkg:SDK
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4338 +/- ##
=====================================
Coverage 83.4% 83.4%
=====================================
Files 185 185
Lines 14329 14332 +3
=====================================
+ Hits 11955 11960 +5
+ Misses 2147 2145 -2
Partials 227 227
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Jul 18, 2023
dmathieu
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3835
Detect duplicate instrument registrations for instruments that have the same case-insensitive names. Continue to return the instruments with different names, but log a warning. This is the solution proposed in open-telemetry/opentelemetry-specification#3606.
This does not address the log message not containing a view recipe to resolve the conflict. That is left to #4203.