Restrict Meters to only register and collect instruments it created #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4333 +/- ##
=======================================
- Coverage 83.5% 83.4% -0.1%
=======================================
Files 184 184
Lines 14366 14365 -1
=======================================
- Hits 11997 11990 -7
- Misses 2143 2149 +6
Partials 226 226
|
MrAlias
changed the title
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Jul 18, 2023
dmathieu
approved these changes
Jul 19, 2023
hanyuancheung
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow the registration or collection of data for instruments from other
Meters with the same scope (i.e. from differentMeterProviders) (resolves #4164). Do this by comparing the instance of the meter that created an instrument with the meter the operation is being run for.