Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decision about v2 API #3968

Merged
merged 11 commits into from
Jun 21, 2023
Merged

Conversation

MadVikingGod
Copy link
Contributor

This leaves a record in our document about the findings of V2, and how we won't use a v2.

Closes: #3920

This does add procedural language about how updates around an API change will happen. These are my suggestion, and I am open to a different approach.

@MadVikingGod MadVikingGod added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 4, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member

mx-psi commented Apr 10, 2023

I believe this also closes #3277

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #3968 (05a1760) into main (fc88a6a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3968   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        181     181           
  Lines      14115   14115           
=====================================
  Hits       11783   11783           
  Misses      2105    2105           
  Partials     227     227           

see 2 files with indirect coverage changes

@pellared pellared changed the title Add decision about V2 api. Add decision about v2 API May 31, 2023
@pellared
Copy link
Member

@open-telemetry/go-maintainers Can you please double-check? I am leaning towards merging this PR.

@pellared
Copy link
Member

pellared commented Jun 1, 2023

Waiting a week before merging.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Steven E. Harris <[email protected]>
CONTRIBUTING.md Outdated Show resolved Hide resolved
@pellared pellared merged commit 9c61b56 into open-telemetry:main Jun 21, 2023
@MrAlias MrAlias added this to the v1.17.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Use a V2 API to evolve interfaces
8 participants